Re: [PATCH v1 3/5] dt-bindings: net: Add HPE GXP UMAC

From: Andrew Lunn
Date: Fri Jul 21 2023 - 18:01:49 EST


> +examples:
> + - |
> + ethernet@4000 {
> + compatible = "hpe,gxp-umac";
> + reg = <0x4000 0x80>;
> + interrupts = <22>;
> + mac-address = [00 00 00 00 00 00]; /* Filled in by U-Boot */

Do both ports get the sane MAC address?

> + ethernet-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + phy-handle = <&eth_phy0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> + phy-handle = <&eth_phy1>;
> + };
> + };
> +
> + mdio {

This seems to be wrong. You have a standalone MDIO bus driver, not
part of the MAC address space?

Andrew