Re: [PATCH v3 18/42] spi: ep93xx: add DT support for Cirrus EP93xx

From: Andy Shevchenko
Date: Fri Jul 21 2023 - 12:43:31 EST


On Thu, Jul 20, 2023 at 02:29:18PM +0300, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@xxxxxxxxxxx>
>
> - add OF ID match table
>
> Instead of platform use_dma flag - check if DT dmas property is present to
> decide to use dma ot not.

...

> +#ifdef CONFIG_OF

Why ifdeffery?

Can't it be first checked for firmware provided info and fell back to platdata?

> +static struct ep93xx_spi_info dt_spi_info;

...

> +#endif

--
With Best Regards,
Andy Shevchenko