Re: [PATCH v2] selftests: prctl: Add new prctl test for PR_SET_NAME

From: Shuah Khan
Date: Fri Jul 21 2023 - 12:33:32 EST


On 7/14/23 10:21, Shuah Khan wrote:
On 6/26/23 12:36, Osama Muhammad wrote:
Hi Shuah,

Any feedback on this patch?.

Thanks,
Osama



Please don't top post when you are responding on kernel
mailing lists. It gets very difficult to follow the
comments in the email thread.

On Sat, 17 Jun 2023 at 18:01, Osama Muhammad <osmtendev@xxxxxxxxx> wrote:

Hi,

Yes, I did install the latest kernel headers and TASK_COMM_LEN is not
accessible in userspace.

I looked into the test which uses TASK_COMM_LEN but the test defines
it in its own header file.

Example:  https://elixir.bootlin.com/linux/latest/source/tools/testing/selftests/bpf/progs/pyperf.h#L13

bfp test does things differently because its dependencies
on run-time environment.


TASK_COMM_LEN is defined in include/linux/sched.h, but this header
file is not exposed to userspace.

Correct. you can include linux/sched.h like other tests do
Take a look at tools/testing/selftests/clone3


You are right about TASK_COMM_LEN not visible to user-space.
This patch has been applied to linux-kselftest next for 6.6-rc1

thanks,
-- Shuah