Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload

[Krzysztof Kozlowski]

On 21/07/2023 17:28, Ng, Boon Khai wrote:
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> Sent: Friday, July 21, 2023 6:11 PM
>> To: Boon@xxxxxxxxxxxxxxxxxxxx; Khai@xxxxxxxxxxxxxxxxxxxx; "Ng
>> <boon.khai.ng"@intel.com; Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>;
>> Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>; Jose Abreu
>> <joabreu@xxxxxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Eric
>> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
>> Abeni <pabeni@xxxxxxxxxx>; Maxime Coquelin
>> <mcoquelin.stm32@xxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-stm32@st-md-
>> mailman.stormreply.com; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx
>> Cc: Ng, Boon Khai <boon.khai.ng@xxxxxxxxx>; Shevchenko, Andriy
>> <andriy.shevchenko@xxxxxxxxx>; Tham, Mun Yew <mun.yew.tham@xxxxxxxxx>;
>> Swee, Leong Ching <leong.ching.swee@xxxxxxxxx>; G Thomas, Rohan
>> <rohan.g.thomas@xxxxxxxxx>; Shevchenko Andriy
>> <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings:
>> net: snps,dwmac: Add description for rx-vlan-offload
>>
>> On 21/07/2023 08:26, Boon@xxxxxxxxxxxxxxxxxxxx wrote:
>>> From: Boon Khai Ng <boon.khai.ng@xxxxxxxxx>
>>>
>>> This patch is to add the dts setting for the MAC controller on
>>> synopsys 10G Ethernet MAC which allow the 10G MAC to turn on hardware
>>> accelerated VLAN stripping. Once the hardware accelerated VLAN
>>> stripping is turn on, the VLAN tag will be stripped by the
>>
>> Subject prefix is totally bogus.
>>
> 
> Which part? It's a 10G Ethernet IP from Sysnopsys, in Roman character it is X (mean 10), so XGMAC.
> Even the driver file I'm editing it is dw"xgmac".

Everything in [].

> 
>>
>>> 10G Ethernet MAC.
>>>
>>> Signed-off-by: Boon Khai Ng <boon.khai.ng@xxxxxxxxx>
>>> Reviewed-by: Shevchenko Andriy <andriy.shevchenko@xxxxxxxxxxxxxxx>
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>> to CC. It might happen, that command when run on an older kernel, gives you
>> outdated entries. Therefore please be sure you base your patches on recent
>> Linux kernel.
>>
> 
> This is based on net-next repository suggested by the get maintainer script.
> 
> I got the latest net-next just now at the Commit-id b44693495af8 
> which just committed yesterday.
> 
> $ ./scripts/get_maintainer.pl  --scm  -f drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c

That's not how you run it. get_maintainers.pl should be run on patches
or on all files, not just some selection.

> Giuseppe Cavallaro <peppe.cavallaro@xxxxxx> (supporter:STMMAC ETHERNET DRIVER)
> Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx> (supporter:STMMAC ETHERNET DRIVER)
> Jose Abreu <joabreu@xxxxxxxxxxxx> (supporter:STMMAC ETHERNET DRIVER)
> "David S. Miller" <davem@xxxxxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
> Eric Dumazet <edumazet@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
> Jakub Kicinski <kuba@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
> Paolo Abeni <pabeni@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
> Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx> (maintainer:ARM/STM32 ARCHITECTURE)
> Richard Cochran <richardcochran@xxxxxxxxx> (maintainer:PTP HARDWARE CLOCK SUPPORT)
> netdev@xxxxxxxxxxxxxxx (open list:STMMAC ETHERNET DRIVER)
> linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx (moderated list:ARM/STM32 ARCHITECTURE)
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:ARM/STM32 ARCHITECTURE)
> linux-kernel@xxxxxxxxxxxxxxx (open list)
> git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
> git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
> git git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
> git git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> 
>> You missed at least DT list (maybe more), so this won't be tested by automated
>> tooling. Performing review on untested code might be a waste of time, thus I
>> will skip this patch entirely till you follow the process allowing the patch to be
>> tested.
>>
> 
> This is a new device bringup, thus the DT is not available yet. The DTS will be upstreamed
> by my another colleague, unless, if I can upstream only my part on the setting? 

You are mixing now DTS and DT bindings. Sorry, we do not talk about DTS.

Follow our process of submitting patches. For sure there are folks in
Intel which can explain it to you.


Best regards,
Krzysztof