Re: [PATCH net-next] page_pool: split types and declarations from page_pool.h

From: Alexander Lobakin
Date: Fri Jul 21 2023 - 11:54:02 EST


From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Fri, 21 Jul 2023 07:56:15 -0700

> On Fri, 21 Jul 2023 19:12:25 +0800 Yunsheng Lin wrote:
>> Just to be clear, include/net/page_pool.h is still there, we are not
>> putting page_pool.h in include/net/page_pool/ and renaming it to
>> something else, right? As there is no that kind of uniformity in
>> include/net/* as far as I can see.
>
> Like many things the uniformity is a plan which mostly exists in my head
> at this stage :) But it is somewhat inspired by include/linux/sched.*
>
>> More specificly, yon means the below, right?
>> include/net/page_pool.h
>> include/net/page_pool/types.h
>
> Yes.

What I meant is

include/net/page_pool/types.h
include/net/page_pool/driver.h

I'm not insisting, just to be clear :)

Thanks,
Olek