Re: [PATCH AUTOSEL 6.4 11/12] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver

[Sasha Levin]

On Mon, Jul 03, 2023 at 11:14:37AM +0100, Mark Rutland wrote:
> On Sun, Jul 02, 2023 at 03:50:56PM -0400, Sasha Levin wrote:
> > From: Junhao He <hejunhao3@xxxxxxxxxx>
> >
> > [ Upstream commit 1a51688474c0d395b864e98236335fba712e29bf ]
> >
> > Compared to the original PA device, H60PA offers higher bandwidth.
> > The H60PA is a new device and we use HID to differentiate them.
> >
> > The events supported by PAv3 and PAv2 are different. The PAv3 PMU
> > removed some events which are supported by PAv2 PMU. The older PA
> > PMU driver will probe v3 as v2. Therefore PA events displayed by
> > "perf list" cannot work properly. We add the HISI0275 HID for PAv3
> > PMU to distinguish different.
> >
> > For each H60PA PMU, except for the overflow interrupt register, other
> > functions of the H60PA PMU are the same as the original PA PMU module.
> > It has 8-programable counters and each counter is free-running.
> > Interrupt is supported to handle counter (64-bits) overflow.
> >
> > Signed-off-by: Junhao He <hejunhao3@xxxxxxxxxx>
> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> > Reviewed-by: Yicong Yang <yangyicong@xxxxxxxxxxxxx>
> > Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
> > Link: https://lore.kernel.org/r/20230615125926.29832-2-hejunhao3@xxxxxxxxxx
> > Signed-off-by: Will Deacon <will@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> >  drivers/perf/hisilicon/hisi_uncore_pa_pmu.c | 127 +++++++++++++++++---
> >  drivers/perf/hisilicon/hisi_uncore_pmu.h    |   8 ++
> >  2 files changed, 120 insertions(+), 15 deletions(-)
>
> Why is this being backported to stable?
>
> This patch adds supoprt for new HW, and is clearly not a fix, so it's not clear
> to me why it has been selected.

I'll drop it, thanks.

--
Thanks,
Sasha