Re: [PATCH 1/7] x86/amd_nb: Add AMD Family 19h Models(80h-80fh) and (90h-9fh) PCI IDs

From: Yazen Ghannam
Date: Fri Jul 21 2023 - 10:44:54 EST


On 7/20/2023 8:54 AM, Muralidhara M K wrote:
From: Muralidhara M K <muralidhara.mk@xxxxxxx>

Add new Root, Device 18h Function 3, and Function 4 PCI IDS
for x86 AMD family 19h, Models 80h-80fh and 90h-9fh.


$SUBJECT and commit message reference Family/Models, but the patch uses the code name MI300.

I suggest using MI300 in the $SUBJECT. And highlight in the message that both groups of MI300 use the same IDs. You can clarify that Models 80h-8Fh are MI300C and 90h-9Fh are MI300A.

Thanks,
Yazen