Re: [PATCH v1 1/1] ALSA: korg1212: Re-use sockptr_t and respective APIs

From: Andy Shevchenko
Date: Fri Jul 21 2023 - 08:58:33 EST


On Fri, Jul 21, 2023 at 12:58:14PM +0200, Takashi Iwai wrote:
> On Fri, 21 Jul 2023 12:42:08 +0200,
> Andy Shevchenko wrote:
> > On Fri, Jul 21, 2023 at 12:08:46PM +0200, Takashi Iwai wrote:
> > > On Fri, 21 Jul 2023 12:01:46 +0200,
> > > Andy Shevchenko wrote:

...

> > > While I see the benefit, I feel this is very confusing. If we use the
> > > API for a generic use, it should be renamed at first.

> > Any suggestion for the name?
>
> It's a universal pointer... uniptr_t?
> Or a generic pointer, genptr_t?
>
> I'm not good at naming, and I'm open for it.

It seems it's already spread enough with this name, I would rather stick with
it for now (besides net it's used in crypto, nvme, and security).

The (new) callback though makes a lot of sense on its own.

What do you think?

--
With Best Regards,
Andy Shevchenko