Re: [PATCH v3 3/3] serial: core: Fix serial core controller port name to show controller id

[Andy Shevchenko]

On Fri, Jul 21, 2023 at 10:21:42AM +0300, Tony Lindgren wrote:
> We are missing the serial core controller id for the serial core port
> name. Let's fix the issue for sane /sys/bus/serial-core/devices, and to
> avoid issues addressing serial ports later on.

...

> +	if (type == &serial_ctrl_type)
> +		return dev_set_name(dev, "%s.%s.%d", type->name,

> +	else if (type == &serial_port_type)
> +		return dev_set_name(dev, "%s.%s.%d.%d", type->name,
> +				    dev_name(port->dev), ctrl_id,
> +				    port_id);
> +	else

Redundant 'else' in both cases.

> +		return -EINVAL;

-- 
With Best Regards,
Andy Shevchenko