Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

[Krzysztof Kozlowski]

On 20/07/2023 14:40, Viktar Simanenka wrote:
> Add device tree binding documentation for PCD8544 LCD display controller.
> 
> Signed-off-by: Viktar Simanenka <viteosen@xxxxxxxxx>
> ---
> v3:add a little more description to the exposed vendor properties
>    add commit message finally
> v2 link: https://lore.kernel.org/linux-devicetree/20230719154450.620410-1-viteosen@xxxxxxxxx/
> 
>  .../bindings/display/nxp,pcd8544.yaml         | 95 +++++++++++++++++++
>  1 file changed, 95 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/nxp,pcd8544.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/nxp,pcd8544.yaml b/Documentation/devicetree/bindings/display/nxp,pcd8544.yaml
> new file mode 100644
> index 000000000000..bacdeff9776e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/nxp,pcd8544.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/nxp,pcd8544.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Philips Semiconductors PCD8544 LCD Display Controller
> +
> +maintainers:
> +  - Viktar Simanenka <viteosen@xxxxxxxxx>
> +
> +description: |
> +  Philips Semiconductors PCD8544 LCD Display Controller with SPI control bus.
> +  Designed to drive a graphic display of 48 rows and 84 columns,
> +  such as Nokia 5110/3310 LCDs.
> +
> +allOf:
> +  - $ref: panel/panel-common.yaml#

This is not a panel, is it?

> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +

Best regards,
Krzysztof