Re: [PATCH V1 1/1] linux: drivers: mtd: spi-nor: gigadevice.c

[Tudor Ambarus]

On 21.07.2023 10:41, Michael Walle wrote:
>>>
>>> { "gd25q128", INFO(0xc84018, 0, 64 * 1024, 256)
>>>             FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>>
>> The locking support is not part of the JEDEC SFDP standard, but vendors
>> can define their own SFDP tables where they describe the locking
>> support. So for now, if you want to enable locking you have to specify
>> the locking flags, whatever they are. There are different flavors of
>> block protection locking, with 3 or 4 block protection bits, their
>> order, etc. You'll have to check the datasheet.
> 
> I've seen that gigadevice has their own proprietary SFDP table which
> also indicates locking. I'd prefer to have a parser for these, esp.
> because the patch is coming from the vendor itself :)
> 

Yes, I agree.