Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative

[Tony Lindgren]

* Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> [230721 07:07]:
> On Fri, Jul 21, 2023 at 09:57:01AM +0300, Tony Lindgren wrote:
> > * Tony Lindgren <tony@xxxxxxxxxxx> [230721 06:19]:
> > > Looks like linux-serial not getting added is caused by MAINTAINERS
> > > not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This
> > > causes get_maintainer.pl to not show linux-serial for a patch touching
> > > serial_base_bus.c.. And this will causes git send-email to not pick up
> > > linux-serial.. I'll send a patch for MAINTAINERS file too.
> > 
> > And the TTY LAYER is missing the list entries.. Does something like below
> > make sense to you guys to include lkml and linux-serial for TTY LAYER?
> > 
> > Regards,
> > 
> > Tony
> > 
> > 8< ---------------------
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -21628,11 +21628,17 @@ F:	Documentation/translations/zh_TW/
> >  TTY LAYER
> >  M:	Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >  M:	Jiri Slaby <jirislaby@xxxxxxxxxx>
> > +L:	linux-kernel@xxxxxxxxxxxxxxx
> > +L:	linux-serial@xxxxxxxxxxxxxxx
> >  S:	Supported
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> >  F:	Documentation/driver-api/serial/
> >  F:	drivers/tty/
> > +F:	drivers/tty/serial/serial_base.h
> > +F:	drivers/tty/serial/serial_base_bus.c
> >  F:	drivers/tty/serial/serial_core.c
> > +F:	drivers/tty/serial/serial_ctrl.c
> > +F:	drivers/tty/serial/serial_port.c
> >  F:	include/linux/selection.h
> >  F:	include/linux/serial.h
> >  F:	include/linux/serial_core.h
> > -- 
> > 2.41.0
> 
> Seems sane to me, I've always wondered why some serial patches didn't
> end up on the linux-serial list.

OK will send. Also I noticed that using git send-email --cc-cover does
not work for the cover letter.. It tries to use the first patch that
is the cover letter or something like that. I'm going back to my custom
email scripts for now rather than try to have git handle things
automagically.

Regards,

Tony