Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative

From: Tony Lindgren
Date: Fri Jul 21 2023 - 01:43:42 EST


* Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> [230720 19:33]:
> On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote:
> > The controller id cannot be negative.
> >
>
> What does this mean for a changelog?

Just let's fix it while at it and adding port_id in the following patch.
If you prefer I can squash the change into the fix adding port_id.

> And you forgot to cc: linux-serial?
>
> And I never got patch 0/3?
>
> something went wrong here...

Thanks for letting me know, I'll check what went wrong..

> > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
> > Reported-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Closes: https://lore.kernel.org/linux-serial/ZLd154hdaSG2lnue@xxxxxxxxxxxxxxxxxx/#t
>
> This isn't a bug report to close, is it?

OK will leave it out. I added it as checkpatch.pl now warns if Reported-by
is added without Closes.

Regards,

Tony