Re: [PATCH v2 04/12] rust: init: wrap type checking struct initializers in a closure

From: Martin Rodriguez Reboredo
Date: Thu Jul 20 2023 - 20:25:42 EST


On 7/19/23 11:20, Benno Lossin wrote:
In the implementation of the init macros there is a `if false` statement
that type checks the initializer to ensure every field is initialized.
Since the next patch has a stack variable to store the struct, the
function might allocate too much memory on debug builds. Putting the
struct into a closure that is never executed ensures that even in debug
builds no stack overflow error is caused. In release builds this was not
a problem since the code was optimized away due to the `if false`.

Signed-off-by: Benno Lossin <benno.lossin@xxxxxxxxx>
---
[...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>