Re: [PATCH] kbuild: rust: avoid creating temporary files

From: Masahiro Yamada
Date: Thu Jul 20 2023 - 14:35:12 EST


On Fri, Jul 21, 2023 at 2:30 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Thu, Jul 20, 2023 at 7:18 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > Applied to linux-kbuild/fixes. Thanks.
> >
> > I believe this is a fix, so I will include it
> > in my next pull request.
>
> Thanks Masahiro! Yeah, it can be considered a fix. By the way, in case you want:
>
> Fixes: 2f7ab1267dc9 ("Kbuild: add Rust support")


Maybe, the following was a breakage.


commit 295d8398c67e314d99bb070f38883f83fe94a97a
Author: Masahiro Yamada <masahiroy@xxxxxxxxxx>
Date: Sat Jan 7 18:18:15 2023 +0900

kbuild: specify output names separately for each emission type from rustc




Before that, rust_common_cmd had --out-dir.


BTW, do we also need to fix scripts/Makefile.host
in case the external module Makefile creates host programs?







> I guess it can be also considered a feature (e.g. "supporting more
> setups"), but having the temporaries created where they were was
> unintentional.





--
Best Regards
Masahiro Yamada