Re: [PATCH v4 1/5] thermal/drivers/tsens: Add TSENS enable and calibration support for V2
From: kernel test robot
Date: Thu Jul 20 2023 - 12:54:32 EST
Hi Praveenkumar,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on robh/for-next linus/master v6.5-rc2 next-20230720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Praveenkumar-I/thermal-drivers-tsens-Add-TSENS-enable-and-calibration-support-for-V2/20230719-184436
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link: https://lore.kernel.org/r/20230719104041.126718-2-quic_ipkumar%40quicinc.com
patch subject: [PATCH v4 1/5] thermal/drivers/tsens: Add TSENS enable and calibration support for V2
config: arm-randconfig-r001-20230720 (https://download.01.org/0day-ci/archive/20230721/202307210014.qNnx99K8-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20230721/202307210014.qNnx99K8-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307210014.qNnx99K8-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/thermal/qcom/tsens-v2.c:153:9: error: implicit declaration of function 'FIELD_PREP' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
val = FIELD_PREP(CONVERSION_SHIFT_MASK, V2_SHIFT_DEFAULT) |
^
1 error generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SM_GCC_8450
Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
Selected by [y]:
- SM_VIDEOCC_8450 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
WARNING: unmet direct dependencies detected for SM_GCC_8550
Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
Selected by [y]:
- SM_GPUCC_8550 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
vim +/FIELD_PREP +153 drivers/thermal/qcom/tsens-v2.c
129
130 static int tsens_v2_calibrate_sensor(struct device *dev, struct tsens_sensor *sensor,
131 struct regmap *map, u32 mode, u32 base0, u32 base1)
132 {
133 u32 slope, czero, val;
134 char name[8];
135 int ret;
136
137 /* Read offset value */
138 ret = snprintf(name, sizeof(name), "s%d", sensor->hw_id);
139 if (ret < 0)
140 return ret;
141
142 ret = nvmem_cell_read_variable_le_u32(dev, name, &sensor->offset);
143 if (ret)
144 return ret;
145
146 /* Based on calib mode, program SHIFT, SLOPE and CZERO */
147 switch (mode) {
148 case TWO_PT_CALIB:
149 slope = (TWO_PT_SHIFTED_GAIN / (base1 - base0));
150
151 czero = (base0 + sensor->offset - ((base1 - base0) / 3));
152
> 153 val = FIELD_PREP(CONVERSION_SHIFT_MASK, V2_SHIFT_DEFAULT) |
154 FIELD_PREP(CONVERSION_SLOPE_MASK, slope) |
155 FIELD_PREP(CONVERSION_CZERO_MASK, czero);
156
157 fallthrough;
158 case ONE_PT_CALIB2:
159 czero = base0 + sensor->offset - ONE_PT_CZERO_CONST;
160
161 val = FIELD_PREP(CONVERSION_SHIFT_MASK, V2_SHIFT_DEFAULT) |
162 FIELD_PREP(CONVERSION_SLOPE_MASK, ONE_PT_SLOPE) |
163 FIELD_PREP(CONVERSION_CZERO_MASK, czero);
164
165 break;
166 default:
167 dev_dbg(dev, "calibrationless mode\n");
168
169 val = FIELD_PREP(CONVERSION_SHIFT_MASK, V2_SHIFT_DEFAULT) |
170 FIELD_PREP(CONVERSION_SLOPE_MASK, V2_SLOPE_DEFAULT) |
171 FIELD_PREP(CONVERSION_CZERO_MASK, V2_CZERO_DEFAULT);
172 }
173
174 regmap_write(map, SENSOR_CONVERSION(sensor->hw_id), val);
175
176 return 0;
177 }
178
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki