Re: [PATCH v3 4/4] ARM: dts: imx6q: Add Variscite MX6 Custom board support

[Fabio Estevam]

On Thu, Jul 20, 2023 at 10:10 AM James Hilliard
<james.hilliard1@xxxxxxxxx> wrote:

> +       reg_audio: regulator-audio {
> +               compatible = "regulator-fixed";
> +               regulator-name = "tlv320aic3x-supply";
> +               enable-active-high;

There is no gpio associated, so 'enable-active-high' should be removed.

> +       backlight_lvds: backlight-lvds {
> +               compatible = "pwm-backlight";
> +               pwms = <&pwm2 0 50000 0>;
> +               brightness-levels = <0 4 8 16 32 64 128 248>;
> +               default-brightness-level = <7>;
> +               power-supply = <&reg_pu>;

Is this correct? reg_pu is an internal regulator and should supply the
internal SoC peripherals.

> +       };

> +&iomuxc {
> +       pinctrl_ipu1: ipu1grp {
> +               fsl,pins = <
> +                       MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK      0x10
> +                       MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15            0x10
> +                       MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02             0x10
> +                       MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03             0x10
> +                       MX6QDL_PAD_DI0_PIN4__IPU1_DI0_PIN04             0x10
> +                       MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00        0x10
> +                       MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01        0x10
> +                       MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02        0x10
> +                       MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03        0x10
> +                       MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04        0x10
> +                       MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05        0x10
> +                       MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06        0x10
> +                       MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07        0x10
> +                       MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08        0x10
> +                       MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09        0x10
> +                       MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10       0x10
> +                       MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11       0x10
> +                       MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12       0x10
> +                       MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13       0x10
> +                       MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14       0x10
> +                       MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15       0x10
> +                       MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16       0x10
> +                       MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17       0x10
> +                       MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18       0x10
> +                       MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19       0x10
> +                       MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20       0x10
> +                       MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21       0x10
> +                       MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22       0x10
> +                       MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23       0x10
> +               >;
> +       };
> +
> +       pinctrl_ipu1: ipu1grp {

pinctrl_ipu1 appears twice. This second entry should be pinctrl_camera
or something like that.

> +       pinctrl_flexcan1: flexcan1grp {
> +               fsl,pins = <
> +                       MX6QDL_PAD_GPIO_7__FLEXCAN1_TX          0x1b0b0
> +                       MX6QDL_PAD_GPIO_8__FLEXCAN1_RX          0x1b0b0

Move pinctrl_flexcan1 to keep the pinctrl entries sorted.

> +
> +&ldb {
> +       status = "okay";
> +
> +       lvds-channel@0 {
> +               fsl,data-mapping = "spwg";
> +               fsl,data-width = <24>;
> +               status = "okay";

Add a new line.

> +               port@4 {
> +                       reg = <4>;
> +
> +                       lvds0_out: endpoint {
> +                               remote-endpoint = <&panel_in_lvds0>;
> +                       };
> +               };
> +       };
> +
> +       lvds-channel@1 {
> +               fsl,data-mapping = "spwg";
> +               fsl,data-width = <24>;
> +               status = "okay";

Add a new line.

> +               port@4 {