Re: [PATCH v3 2/4] ARM: dts: imx6qdl: Add Variscite VAR-SOM-MX6 SoM support

[Fabio Estevam]

On Thu, Jul 20, 2023 at 10:10 AM James Hilliard
<james.hilliard1@xxxxxxxxx> wrote:

> +       reg_audio: regulator-audio {
> +               compatible = "regulator-fixed";
> +               regulator-name = "tlv320aic3x-supply";
> +               enable-active-high;

enable-active-high should only be used when there is a corresponding
gpio property.

> +&ecspi3 {
> +       fsl,spi-num-chipselects = <1>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_ecspi3>;
> +       cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;

This should be ACTIVE_LOW instead.

> +       status = "okay";
> +};
> +
> +&fec {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_enet>;
> +       phy-mode = "rgmii";
> +       phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;

This is a deprecated property.

The recommendation is to add a mdio node with:

reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
reset-assert-us = <10000>;

Is this an Atheros AR8031 PHY. If so, please check imx6qdl-sabresd.dtsi.

> +&ssi2 {
> +       fsl,mode = "i2s-slave";

This is unused, drop it.

Please check commit ece1e4999 606 ("ASoC: fsl_ssi: Remove unneeded
'i2s-slave' property")

> +&usdhc3 {
> +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +       pinctrl-0 = <&pinctrl_usdhc3>;
> +       pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> +       pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> +       bus-width = <4>;
> +       vmmc-supply = <&reg_wl18xx_vmmc>;
> +       non-removable;
> +       wakeup-source;
> +       keep-power-in-suspend;
> +       cap-power-off-card;
> +       #address-cells = <1>;
> +       #size-cells = <0>;
> +       status = "okay";
> +
> +       wifi: wifi@0 {
> +               compatible = "ti,wl1835";
> +               reg = <2>;

@0 and reg = <2> do not match.