Re: [PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code

From: Krzysztof Kozlowski
Date: Thu Jul 20 2023 - 08:35:58 EST


On 20/07/2023 14:31, Przemyslaw wrote:
> From: Przemyslaw Chwiala <przemekchwiala@xxxxxxxxx>
>
> Using CONFIG_ prefix for macros is not a good practice.
> Use CONFIG_ prefix in Kconfig only.
>
> Signed-off-by: Przemyslaw Chwiala <przemekchwiala@xxxxxxxxx>
> ---

For future:
Please provide changelog after --- and version your patches (git
format-patch -v2, or use b4).


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you do not know the process, here is a short
explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

Best regards,
Krzysztof