Re: [PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code

From: Krzysztof Kozlowski
Date: Thu Jul 20 2023 - 08:29:11 EST

Next message: Kai Huang: "[PATCH v2 04/11] x86/tdx: Rename __tdx_module_call() to __tdcall()"
Previous message: Kai Huang: "[PATCH v2 03/11] x86/tdx: Make macros of TDCALLs consistent with the spec"
In reply to: Przemyslaw: "[PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code"
Next in thread: Przemyslaw: "[PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 20/07/2023 14:25, Przemyslaw wrote:
> From: przemoch <przemekchwiala@xxxxxxxxx>

Please use the same name in commit author and SoB.

>
> Using CONFIG_ prefix for macros is not a good practice.
> Use CONFIG_ prefix in Kconfig only.
>
> Signed-off-by: Przemyslaw Chwiala <przemekchwiala@xxxxxxxxx>

Code is okay, so please send v2 with fixed author.

Best regards,
Krzysztof

Next message: Kai Huang: "[PATCH v2 04/11] x86/tdx: Rename __tdx_module_call() to __tdcall()"
Previous message: Kai Huang: "[PATCH v2 03/11] x86/tdx: Make macros of TDCALLs consistent with the spec"
In reply to: Przemyslaw: "[PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code"
Next in thread: Przemyslaw: "[PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]