Re: [PATCH 00/11] drm: kunit: Switch to kunit actions

[Maxime Ripard]

Hi,

On Mon, Jul 17, 2023 at 11:24:13PM +0800, suijingfeng wrote:
> On 2023/7/10 15:47, Maxime Ripard wrote:
> > Hi,
> > 
> > Since v6.5-rc1, kunit gained a devm/drmm-like mechanism that makes tests
> > resources much easier to cleanup.
> > 
> > This series converts the existing tests to use those new actions were
> > relevant.
> 
> Is the word 'were' here means that 'where' relevant ?

Yes :)

> Or it is means that it were relevant, after applied you patch it is not
> relevant anymore ?
> 
> > Let me know what you think,
> > Maxime
> > 
> > Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx>
> > ---
> > Maxime Ripard (11):
> >        drm/tests: helpers: Switch to kunit actions
> >        drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device()
> >        drm/tests: modes: Remove call to drm_kunit_helper_free_device()
> >        drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device()
> >        drm/tests: helpers: Create an helper to allocate a locking ctx
> >        drm/tests: helpers: Create an helper to allocate an atomic state
> 
> a helper or an helper ?
> 
> Should this two patch be re-titled as following ?
> 
> I search it on the internet[1], mostly using a helper.
> 
> 
>       drm/tests: helpers: Create a helper to allocate a locking ctx
>       drm/tests: helpers: Create a helper to allocate an atomic state
> 
> [1] https://www.a-or-an.com/a_an/helper
> 
> Sorry about the noise if I'm wrong.

You're right, I'll fix it

Thanks!
Maxime

Attachment: signature.asc
Description: PGP signature