Re: [PATCH 2/2] ARM: dts: imx6q: Add Variscite MX6 Custom board support

From: James Hilliard
Date: Wed Jul 19 2023 - 18:43:58 EST


On Wed, Jul 19, 2023 at 1:32 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> > +
> > + pinctrl_ipu1: ipu1grp {
> > + fsl,pins = <
> > + MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0x10
> > + MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15 0x10
> > + MX6QDL_PAD_DI0_PIN2__IPU1_DI0_PIN02 0x10
> > + MX6QDL_PAD_DI0_PIN3__IPU1_DI0_PIN03 0x10
> > + MX6QDL_PAD_DI0_PIN4__IPU1_DI0_PIN04 0x80000000
>
> No 0x80000000 please. Use the real pad ctl value instead.
> This applies globally.

How would I determine what the value of these should be?

The vendor device trees are using 0x80000000 for these values from
what I can tell.