Re: [PATCH v3 1/9] video/aperture: Add a helper to detect if an aperture contains firmware FB

[suijingfeng]

Hi,


On 2023/7/20 04:43, Bjorn Helgaas wrote:
> On Wed, Jul 12, 2023 at 12:43:02AM +0800, Sui Jingfeng wrote:
> > From: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> >
> > This patch adds the aperture_contain_firmware_fb() function to do the
> > determination. Unfortunately, due to the fact that the apertures list
> > will be freed dynamically, the location and size information of the
> > firmware FB will be lost after dedicated drivers call
> > aperture_remove_conflicting_devices(),
> > aperture_remove_conflicting_pci_devices() or
> > aperture_remove_all_conflicting_devices() functions
> > We solve this problem by introducing two static variables that record the
> > firmware framebuffer's start addrness and end addrness. It assumes that the
> > system has only one active firmware framebuffer driver at a time. We don't
> > use the global structure screen_info here, because PCI resources may get
> > reallocated (the VRAM BAR could be moved) during the kernel boot stage.
> s/addrness/address/ (twice)


Will be fixed at the next version, thanks.