Re: [PATCH] clk: imx93: Propagate correct error in imx93_clocks_probe()

From: Stephen Boyd
Date: Wed Jul 19 2023 - 17:05:43 EST


Quoting Geert Uytterhoeven (2023-07-11 08:08:12)
> smatch reports:
>
> drivers/clk/imx/clk-imx93.c:294 imx93_clocks_probe() error: uninitialized symbol 'base'.
>
> Indeed, in case of an error, the wrong (yet uninitialized) variable is
> converted to an error code and returned.
> Fix this by propagating the error code in the correct variable.
>
> Fixes: e02ba11b45764705 ("clk: imx93: fix memory leak and missing unwind goto in imx93_clocks_probe")
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/9c2acd81-3ad8-485d-819e-9e4201277831@kadam.mountain
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/all/202306161533.4YDmL22b-lkp@xxxxxxxxx/
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---

Applied to clk-fixes