Re: [PATCH] serial: core: Add support for dev_name:0.0 naming for kernel console
From: kernel test robot
Date: Wed Jul 19 2023 - 14:04:21 EST
Hi Tony,
kernel test robot noticed the following build errors:
[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.5-rc2 next-20230719]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Tony-Lindgren/serial-core-Add-support-for-dev_name-0-0-naming-for-kernel-console/20230719-131657
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20230719051525.46494-1-tony%40atomide.com
patch subject: [PATCH] serial: core: Add support for dev_name:0.0 naming for kernel console
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20230720/202307200137.Wk1s5BY7-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230720/202307200137.Wk1s5BY7-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307200137.Wk1s5BY7-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/tty/serial/serial_core.c: In function 'serial_core_add_preferred_console':
>> drivers/tty/serial/serial_core.c:3337:36: error: 'struct uart_port' has no member named 'port_id'
3337 | port->port_id);
| ^~
vim +3337 drivers/tty/serial/serial_core.c
3324
3325 /*
3326 * Add preferred console if configured on kernel command line with naming
3327 * "console=dev_name:0.0".
3328 */
3329 static int serial_core_add_preferred_console(struct uart_driver *drv,
3330 struct uart_port *port)
3331 {
3332 char *port_match, *opt, *name;
3333 int len, ret = 0;
3334
3335 port_match = kasprintf(GFP_KERNEL, "console=%s:%i.%i",
3336 dev_name(port->dev), port->ctrl_id,
> 3337 port->port_id);
3338 if (!port_match)
3339 return -ENOMEM;
3340
3341 opt = strstr(saved_command_line, port_match);
3342 if (!opt)
3343 goto free_port_match;
3344
3345 len = strlen(port_match);
3346
3347 if (strlen(opt) > len + 1 && opt[len] == ',')
3348 opt += len + 1;
3349 else
3350 opt = NULL;
3351
3352 name = kstrdup(drv->dev_name, GFP_KERNEL);
3353 if (!name) {
3354 ret = -ENOMEM;
3355 goto free_port_match;
3356 }
3357
3358 add_preferred_console(name, port->line, opt);
3359
3360 kfree(name);
3361
3362 free_port_match:
3363 kfree(port_match);
3364
3365 return ret;
3366 }
3367
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki