Re: [PATCH] scsi/sg: fix checking return value of blk_get_queue()

From: Jens Axboe
Date: Wed Jul 19 2023 - 12:34:17 EST


On 7/18/23 7:09?PM, Yu Kuai wrote:
> Hi, Jens
>
> ? 2023/07/05 10:40, Yu Kuai ??:
>> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>>
>> Commit fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
>> make a mess how blk_get_queue() is called, blk_get_queue() returns true
>> on success while the caller expects it returns 0 on success.
>>
>> Fix this problem and also add a corresponding error message on failure.
>>
>> Fixes: fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
>> Reported-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx>
>> Closes: https://lore.kernel.org/all/87lefv622n.fsf@xxxxxxxxxxxxx/
>> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> Sorry about the trouble... Can you apply this patch? I notice that the
> original patch is applied to stable.

I can, I had assumed that Martin would pick it up on the SCSI side?

--
Jens Axboe