Re: Crash in VirtualBox virtual machines running kernel 6.5

From: Kees Cook
Date: Wed Jul 19 2023 - 11:34:42 EST


On Wed, Jul 19, 2023 at 08:31:08AM -0700, Kees Cook wrote:
> diff --git a/fs/vboxsf/shfl_hostintf.h b/fs/vboxsf/shfl_hostintf.h
> index aca829062c12..243d1b91bb45 100644
> --- a/fs/vboxsf/shfl_hostintf.h
> +++ b/fs/vboxsf/shfl_hostintf.h
> @@ -68,9 +68,8 @@ struct shfl_string {
>
> /** UTF-8 or UTF-16 string. Nul terminated. */
> union {
> - u8 utf8[2];
> - u16 utf16[1];
> - u16 ucs2[1]; /* misnomer, use utf16. */
> + DECLARE_FLEX_ARRAY(u8, utf8);
> + DECLARE_FLEX_ARRAY(u16, utf16);
> } string;
> };
> VMMDEV_ASSERT_SIZE(shfl_string, 6);

Oops, this doesn't even compile. Let me get that fixed...

--
Kees Cook