Re: [V3,02/11] dt-bindings: clock: qcom: gcc-ipq9574: remove q6 bring up clock macros

From: Krzysztof Kozlowski
Date: Wed Jul 19 2023 - 11:21:45 EST


On 19/07/2023 17:11, Manikanta Mylavarapu wrote:
>
>
> On 7/19/2023 12:45 PM, Krzysztof Kozlowski wrote:
>> On 19/07/2023 09:14, Krzysztof Kozlowski wrote:
>>> On 18/07/2023 14:04, Manikanta Mylavarapu wrote:
>>>> In multipd model Q6 firmware takes care of bringup clocks,
>>>> so remove them.
>>>>
>>>> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
>>>> ---
>>>> Changes in V3:
>>>> - Rebased on TOT
>>>
>>> No clue what is TOT. We have TIP, but you should not use it as a base.
>>> Other used names are mainline and linux-next.
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>
>> Un-acked. I said last time that this does not compile and I do not see
>> any improvements here.
>>
>
> My bad, i missed.
>
> Is it fine to move gcc driver patch to first and then dt-bindings
> patch ?
>
> With this way dt-bindings patch will compile.
>
> Current patch order:
> -------------------
> 1) Removing clock macros from dt-bindigs
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20230718120501.3205661-3-quic_mmanikan@xxxxxxxxxxx/
>
> 2) Removing clocks from gcc driver
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20230718120501.3205661-5-quic_mmanikan@xxxxxxxxxxx/
>
>
> Proposed patch order:
> ---------------------
> 1) Removing clocks from gcc driver
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20230718120501.3205661-5-quic_mmanikan@xxxxxxxxxxx/
>
> 2) Removing clock macros from dt-bindigs
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20230718120501.3205661-3-quic_mmanikan@xxxxxxxxxxx/
>

Yes, assuming there are no DTS users.

Best regards,
Krzysztof