Re: [PATCH v3 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic C3 Reset Controller

From: Dmitry Rokosov
Date: Wed Jul 19 2023 - 10:11:26 EST


On Wed, Jul 19, 2023 at 02:33:03PM +0200, Krzysztof Kozlowski wrote:
> On 19/07/2023 13:50, Dmitry Rokosov wrote:
> > On Wed, Jul 19, 2023 at 02:09:52PM +0800, zelong dong wrote:
> >> From: Zelong Dong <zelong.dong@xxxxxxxxxxx>
> >>
> >> Add new compatible and DT bindings for Amlogic C3 Reset Controller
> >>
> >> Signed-off-by: Zelong Dong <zelong.dong@xxxxxxxxxxx>
> >> ---
> >> .../bindings/reset/amlogic,meson-reset.yaml | 1 +
> >> include/dt-bindings/reset/amlogic,c3-reset.h | 119 ++++++++++++++++++
> >> 2 files changed, 120 insertions(+)
> >
> > As I understand it, updates to DT bindings documentation, as well as any
> > DT bindings includes, should be submitted in separate patches, per the
> > guidelines outlined in the following link:
> > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters.
> >
> > Krzysztof, Rob, and Conor, please correct me if I am mistaken.
>
> And they are. What's wrong here?

Please accept my apologies for any confusion caused. Initially, I
misunderstood that YAML documentation and device tree bindings includes
should be kept separate.

As such, this patch includes modifications to both areas, namely
bindings documentation and include/dt-bindings, but all of them are
separate from driver part.

In this case,

Reviewed-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx>

--
Thank you,
Dmitry