Re: [PATCH 1/2] dt-bindings: add vendor-prefixes and bindings for pcd8544 displays

[Krzysztof Kozlowski]

On 19/07/2023 12:24, Viktar Simanenka wrote:
> Signed-off-by: Viktar Simanenka <viteosen@xxxxxxxxx>

Missing commit msg, missing changelog, missing versioning - I already
asked for the last two things.

> ---
>  .../bindings/display/philips,pcd8544.yaml     | 89 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  2 files changed, 91 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/philips,pcd8544.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/philips,pcd8544.yaml b/Documentation/devicetree/bindings/display/philips,pcd8544.yaml
> new file mode 100644
> index 000000000000..ac880d9d8cc1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/philips,pcd8544.yaml
> @@ -0,0 +1,89 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/philips,pcd8544.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Philips PCD8544 LCD Display Controller
> +
> +maintainers:
> +  - Viktar Simanenka <viteosen@xxxxxxxxx>
> +
> +description: |
> +  Philips PCD8544 LCD Display Controller with SPI control bus.
> +  Monochrome 84x48 LCD displays, such as Nokia 5110/3310 LCDs.
> +  May contain backlight LED.
> +
> +allOf:
> +  - $ref: panel/panel-common.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:

That's not oneOf.

> +      - enum:
> +          - philips,pcd8544
> +
> +  dc-gpios:
> +    maxItems: 1
> +    description: Data/Command selection pin (D/CX)
> +
> +  reset-gpios:
> +    maxItems: 1
> +    description: Display Reset pin (RST)
> +
> +  philips,inverted:
> +    type: boolean
> +    description: Display color inversion

Not much improved here. What is it?

> +
> +  philips,voltage-op:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 127
> +    description: Display liquid crystal operation voltage

Voltage is in microvolts (or other *volts). Use proper unit suffix.


> +
> +  philips,bias:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 7
> +    description: Display bias voltage system value

In which units? Voltage is in microvolts.

> +
> +  philips,temperature-coeff:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 3
> +    description: Display temperature compensation coefficient
> +
> +required:
> +  - compatible
> +  - reg
> +  - dc-gpios
> +  - reset-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        display@0 {
> +            compatible = "philips,pcd8544";
> +            spi-max-frequency = <8000000>;
> +            reg = <0>;

reg is always after compatible.

> +
> +            dc-gpios = <&pio 0 3 GPIO_ACTIVE_HIGH>; /* DC=PA3 */
> +            reset-gpios = <&pio 0 1 GPIO_ACTIVE_HIGH>; /* RESET=PA1 */
> +            backlight = <&backlight>;
> +
> +            philips,inverted;
> +            philips,voltage-op = <0>;
> +            philips,bias = <4>;
> +            philips,temperature-coeff = <0>;
> +        };
> +    };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index af60bf1a6664..0c3844af6776 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1037,6 +1037,8 @@ patternProperties:
>      description: Pervasive Displays, Inc.
>    "^phicomm,.*":
>      description: PHICOMM Co., Ltd.
> +  "^philips,.*":
> +    description: Koninklijke Philips N.V.

Isn't this Philips Semiconductors? That's what datasheet is saying.



Best regards,
Krzysztof