Re: [PATCH 5/5] soc: qcom: socinfo: add SM4450 ID

[Krzysztof Kozlowski]

On 19/07/2023 12:01, Tengfei Fan wrote:
> Add the ID for the Qualcomm SM4450 SoC.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> ---
>  drivers/soc/qcom/socinfo.c         | 1 +
>  include/dt-bindings/arm/qcom,ids.h | 2 ++

Bindings are always separate patches.

>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 4d49945b3a35..fa5e4c54207a 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -415,6 +415,7 @@ static const struct soc_id soc_id[] = {
>  	{ qcom_board_id(IPQ5312) },
>  	{ qcom_board_id(IPQ5302) },
>  	{ qcom_board_id(IPQ5300) },
> +	{ qcom_board_id(SM4450) },
>  };
>  
>  static const char *socinfo_machine(struct device *dev, unsigned int id)
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index bcbe9ee2cdaf..6201bfb1405e 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -2,6 +2,7 @@
>  /*
>   * Copyright (c) 2015, The Linux Foundation. All rights reserved.
>   * Copyright (c) 2022 Linaro Ltd
> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
>   * Author: Krzysztof Kozlowski <krzk@xxxxxxxxxx> based on previous work of Kumar Gala.
>   */
>  #ifndef _DT_BINDINGS_ARM_QCOM_IDS_H
> @@ -259,6 +260,7 @@
>  #define QCOM_ID_IPQ5312			594
>  #define QCOM_ID_IPQ5302			595
>  #define QCOM_ID_IPQ5300			624
> +#define QCOM_ID_SM4450			568

No, come on...

Best regards,
Krzysztof