Re: [RFC PATCH 1/4] splice: Fix corruption of spliced data after splice() returns

From: Miklos Szeredi
Date: Wed Jul 19 2023 - 06:18:20 EST


On Thu, 29 Jun 2023 at 17:56, David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Splicing data from, say, a file into a pipe currently leaves the source
> pages in the pipe after splice() returns - but this means that those pages
> can be subsequently modified by shared-writable mmap(), write(),
> fallocate(), etc. before they're consumed.

What is this trying to fix? The above behavior is well known, so
it's not likely to be a problem.

Besides, removing spliced pages from the cache is basically guaranteed
to result in a performance regression for any application using
splice.

Thanks,
Miklos