Re: [RESEND PATCH 2/2] Input: mms114 - add support for touch keys

From: Dmitry Torokhov
Date: Wed Jul 19 2023 - 02:22:35 EST


On Fri, Jul 14, 2023 at 12:04:24PM +0200, Artur Weber wrote:
> + } else if (data->num_keycodes > MMS114_MAX_TOUCHKEYS) {
> + dev_warn(&client->dev,
> + "Found %d linux,keycodes but max is %zd, ignoring the rest\n",
> + data->num_keycodes, MMS114_MAX_TOUCHKEYS);

This gives me the following warning:

drivers/input/touchscreen/mms114.c: In function ‘mms114_probe’:
drivers/input/touchscreen/mms114.c:520:25: error: format ‘%zd’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=]
520 | "Found %d linux,keycodes but max is %zd, ignoring the rest\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I changed the format specifier to "%d" and applied.

Thanks.

--
Dmitry