Re: [PATCH net-next v3 06/11] net: phy: add error checks in mmd_phy_indirect()

[Andrew Lunn]

On Wed, Jul 12, 2023 at 05:07:06PM +0200, Michael Walle wrote:
> Add missing error checks in mmd_phy_indirect(). The error checks need to
> be disabled to retain the current behavior in phy_read_mmd() and
> phy_write_mmd(). Therefore, add a new parameter to enable the error
> checks.
> 
> This is a preparation patch to introduce a new C45-over-C22 access
> method which will make use of the new error checking.
> 
> Regarding the legacy handling, Russell states:
> 
> | The reason for that goes back to commit a59a4d192166 ("phy: add the
> | EEE support and the way to access to the MMD registers.")
> |
> | and to maintain compatibility with that; if we start checking for
> | errors now, we might trigger a kernel regression sadly.
> 
> Signed-off-by: Michael Walle <mwalle@xxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew