Re: [PATCH v2] sparc: Explicitly include correct DT includes

From: Rob Herring
Date: Tue Jul 18 2023 - 15:06:43 EST


On Tue, Jul 18, 2023 at 8:56 AM John Paul Adrian Glaubitz
<glaubitz@xxxxxxxxxxxxxxxxxxx> wrote:
>
> Hi Rob!
>
> On Tue, 2023-07-18 at 08:32 -0600, Rob Herring wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
>
> I would suggest rephrasing the subject to
>
> sparc: Explicitly include correct DT headers
>
> as " ... include ... includes" sounds a bit awkward ;-).

Probably would have been better, but there's ~100 other patches with
the same subject. Some of those have been applied already.

Rob