Re: [PATCH v2 for-rc 3/3] RDMA/hns: Add check and adjust for function resource values

From: kernel test robot
Date: Tue Jul 18 2023 - 13:06:39 EST


Hi Junxian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rdma/for-next]
[also build test WARNING on linus/master v6.5-rc2 next-20230718]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Junxian-Huang/RDMA-hns-support-get-xrcd-num-from-firmware/20230718-171525
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
patch link: https://lore.kernel.org/r/20230717060340.453850-4-huangjunxian6%40hisilicon.com
patch subject: [PATCH v2 for-rc 3/3] RDMA/hns: Add check and adjust for function resource values
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20230719/202307190042.hWzQQIOk-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230719/202307190042.hWzQQIOk-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307190042.hWzQQIOk-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/infiniband/hw/hns/hns_roce_hw_v2.c: In function 'adjust_res_caps':
>> drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1709:53: warning: passing argument 2 of 'check_res_is_supported' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
1709 | if (!check_res_is_supported(hr_dev, &bt_num_table[i]))
| ^~~~~~~~~~~~~~~~
drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1673:60: note: expected 'struct hns_roce_bt_num *' but argument is of type 'const struct hns_roce_bt_num *'
1673 | struct hns_roce_bt_num *bt_num_entry)
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~


vim +1709 drivers/infiniband/hw/hns/hns_roce_hw_v2.c

1699
1700 static u16 adjust_res_caps(struct hns_roce_dev *hr_dev)
1701 {
1702 struct hns_roce_caps *caps = &hr_dev->caps;
1703 u16 invalid_flag = 0;
1704 u32 min, max;
1705 u32 *res;
1706 int i;
1707
1708 for (i = 0; i < ARRAY_SIZE(bt_num_table); i++) {
> 1709 if (!check_res_is_supported(hr_dev, &bt_num_table[i]))
1710 continue;
1711
1712 res = (u32 *)((void *)caps + bt_num_table[i].res_offset);
1713 min = bt_num_table[i].min;
1714 max = bt_num_table[i].max;
1715 if (*res < min || *res > max) {
1716 *res = *res < min ? min : max;
1717 invalid_flag |= 1 << bt_num_table[i].invalid_flag;
1718 }
1719 }
1720
1721 adjust_eqc_bt_num(caps, &invalid_flag);
1722
1723 return invalid_flag;
1724 }
1725

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki