Re: [PATCH] Revert "nvmem: add new config option"
From: kernel test robot
Date: Tue Jul 18 2023 - 12:01:55 EST
Hi Rafał,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mtd/mtd/next]
[also build test WARNING on mtd/mtd/fixes linus/master v6.5-rc2 next-20230718]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rafa-Mi-ecki/Revert-nvmem-add-new-config-option/20230718-170441
base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
patch link: https://lore.kernel.org/r/20230718084804.20139-1-zajec5%40gmail.com
patch subject: [PATCH] Revert "nvmem: add new config option"
config: i386-randconfig-i002-20230718 (https://download.01.org/0day-ci/archive/20230718/202307182316.AVNL1wNs-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230718/202307182316.AVNL1wNs-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307182316.AVNL1wNs-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/mtd/mtdcore.c: In function 'mtd_nvmem_add':
>> drivers/mtd/mtdcore.c:542:29: warning: unused variable 'node' [-Wunused-variable]
542 | struct device_node *node = mtd_get_of_node(mtd);
| ^~~~
vim +/node +542 drivers/mtd/mtdcore.c
c4dfa25ab307a2 Alban Bedel 2018-11-13 539
c4dfa25ab307a2 Alban Bedel 2018-11-13 540 static int mtd_nvmem_add(struct mtd_info *mtd)
c4dfa25ab307a2 Alban Bedel 2018-11-13 541 {
658c4448bbbf02 Christian Marangi 2021-03-12 @542 struct device_node *node = mtd_get_of_node(mtd);
c4dfa25ab307a2 Alban Bedel 2018-11-13 543 struct nvmem_config config = {};
c4dfa25ab307a2 Alban Bedel 2018-11-13 544
75f32f4b9d5263 Miquel Raynal 2023-03-07 545 config.id = NVMEM_DEVID_NONE;
c4dfa25ab307a2 Alban Bedel 2018-11-13 546 config.dev = &mtd->dev;
7b01b7239d0dc9 Ricardo Ribalda 2020-04-30 547 config.name = dev_name(&mtd->dev);
c4dfa25ab307a2 Alban Bedel 2018-11-13 548 config.owner = THIS_MODULE;
c4dfa25ab307a2 Alban Bedel 2018-11-13 549 config.reg_read = mtd_nvmem_reg_read;
c4dfa25ab307a2 Alban Bedel 2018-11-13 550 config.size = mtd->size;
c4dfa25ab307a2 Alban Bedel 2018-11-13 551 config.word_size = 1;
c4dfa25ab307a2 Alban Bedel 2018-11-13 552 config.stride = 1;
c4dfa25ab307a2 Alban Bedel 2018-11-13 553 config.read_only = true;
c4dfa25ab307a2 Alban Bedel 2018-11-13 554 config.root_only = true;
6c7621890995d0 Christophe Kerello 2022-02-20 555 config.ignore_wp = true;
c4dfa25ab307a2 Alban Bedel 2018-11-13 556 config.priv = mtd;
c4dfa25ab307a2 Alban Bedel 2018-11-13 557
c4dfa25ab307a2 Alban Bedel 2018-11-13 558 mtd->nvmem = nvmem_register(&config);
c4dfa25ab307a2 Alban Bedel 2018-11-13 559 if (IS_ERR(mtd->nvmem)) {
c4dfa25ab307a2 Alban Bedel 2018-11-13 560 /* Just ignore if there is no NVMEM support in the kernel */
5cab06156aade1 Miquel Raynal 2023-03-07 561 if (PTR_ERR(mtd->nvmem) == -EOPNOTSUPP)
c4dfa25ab307a2 Alban Bedel 2018-11-13 562 mtd->nvmem = NULL;
5cab06156aade1 Miquel Raynal 2023-03-07 563 else
5cab06156aade1 Miquel Raynal 2023-03-07 564 return dev_err_probe(&mtd->dev, PTR_ERR(mtd->nvmem),
5cab06156aade1 Miquel Raynal 2023-03-07 565 "Failed to register NVMEM device\n");
c4dfa25ab307a2 Alban Bedel 2018-11-13 566 }
c4dfa25ab307a2 Alban Bedel 2018-11-13 567
c4dfa25ab307a2 Alban Bedel 2018-11-13 568 return 0;
c4dfa25ab307a2 Alban Bedel 2018-11-13 569 }
c4dfa25ab307a2 Alban Bedel 2018-11-13 570
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki