Re: [PATCH net-next v2] net: dsa: mv88e6xxx: Add erratum 3.14 for 88E6390X and 88E6190X

From: Andrew Lunn
Date: Tue Jul 18 2023 - 12:00:06 EST


> I don't think so. The erratum from the patch needs to be applied on each
> SERDES reconfiguration or reset. For example, when replugging different
> SFPs (sgmii - 10g - sgmii interface). Erratum 4_6 is done only once?
> My guess is to put it in mv88e639x_sgmii_pcs_post_config but still I
> need the device product number

You might be able to read the product number from the ID registers of
the SERDES, registers 2 and 3 ? That is kind of cleaner. It is the
SERDES which needs the workaround, so look at the SERDES ID ...

- maybe embedding a pointer to the
> mv88e6xxx_chip chip inside the mv88e639x_pcs struct would be the cleanest way.

That would also work.

Andrew