Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver default on platform

[Guenter Roeck]

On 7/18/23 07:42, Henning Schild wrote:
> Am Tue, 18 Jul 2023 17:20:48 +0300
> schrieb Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:
>
> > On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote:
> > > If a user did choose to enable Siemens Simatic platform support they
> > > likely want that driver to be enabled without having to flip more
> > > config switches. So we make the watchdog driver config switch
> > > default to the platform driver switches value.
> >
> > A nit-pick below.
> >
> > ...
> >
> > >   config SIEMENS_SIMATIC_IPC_WDT
> > >   	tristate "Siemens Simatic IPC Watchdog"
> > >   	depends on SIEMENS_SIMATIC_IPC
> >
> > > +	default SIEMENS_SIMATIC_IPC
> >
> > It's more natural to group tristate and default, vs. depends and
> > select.
>
> Will be ignored unless maintainer insists.

Maintainer wants to know why "default SIEMENS_SIMATIC_IPC" is needed
or warranted instead of the much simpler and easier to understand
"default y".

Guenter