Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver default on platform

From: Andy Shevchenko
Date: Tue Jul 18 2023 - 10:21:35 EST


On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote:
> If a user did choose to enable Siemens Simatic platform support they
> likely want that driver to be enabled without having to flip more config
> switches. So we make the watchdog driver config switch default to the
> platform driver switches value.

A nit-pick below.

...

> config SIEMENS_SIMATIC_IPC_WDT
> tristate "Siemens Simatic IPC Watchdog"
> depends on SIEMENS_SIMATIC_IPC

> + default SIEMENS_SIMATIC_IPC

It's more natural to group tristate and default, vs. depends and select.

> select WATCHDOG_CORE
> select P2SB

--
With Best Regards,
Andy Shevchenko