Re: [PATCH] platforms: 52xx: Remove space after '(' and before ')'

[Andy Shevchenko]

On Tue, Jul 18, 2023 at 05:02:39PM +0800, hanyu001@xxxxxxxxxx wrote:
> The patch fixes the following errors detected by checkpatch:
> 
> platforms/52xx/mpc52xx_pci.c:346:ERROR: space prohibited after that open
> parenthesis '('
> platforms/52xx/mpc52xx_pci.c:347:ERROR: space prohibited after that open
> parenthesis '('
> platforms/52xx/mpc52xx_pci.c:348:ERROR: space prohibited before that close
> parenthesis ')'

First of all, your patch is mangled and may not be applied.
Second, we usually don't do this kind of patches at all.
Besides the fact that we don't run checkpatch on the files
which are already in upstream (esp. so-o-o old as this one).

NAK.

...

> +    if ((dev->vendor == PCI_VENDOR_ID_MOTOROLA) &&
> +         (dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200
> +          || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B)) {

Also note, you can move this to use pci_match_id().
That kind of patch might be approved.

-- 
With Best Regards,
Andy Shevchenko