Re: [PATCH v4 2/2] usb: typec: intel_pmc_mux: Configure Active and Retimer Cable type

[Greg KH]

On Mon, Jul 17, 2023 at 07:47:03PM -0700, Utkarsh Patel wrote:
> Cable type such as active and retimer received as a part of Thunderbolt3
> or Thunderbolt4 cable discover mode VDO needs to be configured in the
> thunderbolt alternate mode.
> 
> Configuring the register bits for this cable type is changed with Intel
> Meteor Lake platform. BIT2 for Retimer/Redriver cable and BIT22 for
> Active/Passive cable.
> 
> Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Signed-off-by: Utkarsh Patel <utkarsh.h.patel@xxxxxxxxx>
> ---
> Changes in v4:
>  - No changes.
> 
> Changes in v3:
>  - No changes.
> 
> Changes in v2:
>  - No changes.
> ---
> ---
>  drivers/usb/typec/mux/intel_pmc_mux.c | 28 +++++++++++++++++++++++----
>  1 file changed, 24 insertions(+), 4 deletions(-)

Why the 2 --- lines?

And why are you not cc:ing all the proper people (i.e. the person that
can actually apply this...)?

confused,

greg k-h