Re: [PATCH 3/3] arm64: dts: Add node for chip info driver

[Krzysztof Kozlowski]

On 18/07/2023 13:21, William-tw Lin wrote:
> Add dts node for socinfo retrieval. This includes the following projects:
> MT8173
> MT8183
> MT8186
> MT8192
> MT8195
> 
> Signed-off-by: William-tw Lin <william-tw.lin@xxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 15 +++++++++++++++
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 15 +++++++++++++++
>  arch/arm64/boot/dts/mediatek/mt8186.dtsi | 10 ++++++++++
>  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 14 ++++++++++++++
>  arch/arm64/boot/dts/mediatek/mt8195.dtsi |  9 +++++++++
>  5 files changed, 63 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index c47d7d900f28..115f907751c1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -590,11 +590,26 @@
>  			reg = <0 0x10206000 0 0x1000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> +
> +			socinfo_data1: socinfo-data1 {
> +				reg = <0x040 0x4>;
> +			};
> +
> +			socinfo_data2: socinfo-data2 {
> +				reg = <0x044 0x4>;
> +			};
> +
>  			thermal_calibration: calib@528 {
>  				reg = <0x528 0xc>;
>  			};
>  		};
>  
> +		mtk_socinfo: mtk-socinfo {

Why do you put non-MMIO nodes in MMIO bus?

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof