Re: [PATCH 4/6] clk: qcom: Add NSS clock Controller driver for IPQ9574

[Devi Priya]

On 7/11/2023 3:26 PM, Krzysztof Kozlowski wrote:
> On 11/07/2023 11:35, Devi Priya wrote:
> > Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based
> > devices.
> >
> > Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx>
> > ---
> >   drivers/clk/qcom/Kconfig         |    6 +
> >   drivers/clk/qcom/Makefile        |    1 +
> >   drivers/clk/qcom/nsscc-ipq9574.c | 3080 ++++++++++++++++++++++++++++++
> >   3 files changed, 3087 insertions(+)
> >   create mode 100644 drivers/clk/qcom/nsscc-ipq9574.c
> >
> > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> > index 263e55d75e3f..5556063d204f 100644
> > --- a/drivers/clk/qcom/Kconfig
> > +++ b/drivers/clk/qcom/Kconfig
> > @@ -195,6 +195,12 @@ config IPQ_GCC_9574
> >   	  i2c, USB, SD/eMMC, etc. Select this for the root clock
> >   	  of ipq9574.
> >   
> > +config IPQ_NSSCC_9574
> > +	tristate "IPQ9574 NSS Clock Controller"
>
> I think you do not run arm32 there, so missing depends on ARM64 ||
> COMPILE_TEST

Okay, will update this in V2

Thanks,
Devi Priya
> > +	depends on IPQ_GCC_9574
> > +	help
> > +	  Support for NSS clock controller on ipq9574 devices.
> > +
>
>
> Best regards,
> Krzysztof