Re: [PATCH v3 3/3] net: dsa: mv88e632x: Add SERDES ops

[Sverdlin, Alexander]

Hi Russell,

On Tue, 2023-07-18 at 09:42 +0100, Russell King (Oracle) wrote:
> > > > You need to modify drivers/net/dsa/mv88e6xxx/pcs-6352.c for that.
> > > 
> > > ... and this is why you need to be able to test on recent kernels!
> > 
> > are you absolutely sure about it?
> 
> Yes.
> 
> > mv88e6352_serdes_get_stats() remained in serdes.c after your rework and
> > as I see it, your rework is about link status, but you didn't touch
> > registers and statistics.
> 
> What I said was:
> 
> "but you're not actually driving them at all in terms of reading their
> status or configuring them"
> 
> I was not commenting on obtaining statistics, but the status/control
> of the blocks, which is now in the PCS drivers.
> 
> So, right now it looks to me that _all_ this series is doing is
> providing support to read statistics from the PCS blocks and nothing
> more, so the cover message for this series is misleading. It is not
> adding support for the serdes blocks. It is only adding support for
> reading statistics from the serdes blocks.
> 
> Either correct the patch series to do what the cover message says it's
> doing, or change the cover message to properly describe what the series
> is doing. It needs to be consistent.

thank you, now I see it, .pcs_ops is indeed missing.
And you are right there is no way around it, we will properly port, test
and respin. 

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com