Re: [RFC v2 7/9] kunit: time: Mark test as slow using test attributes

[David Gow]

On Sat, 8 Jul 2023 at 05:10, Rae Moar <rmoar@xxxxxxxxxx> wrote:
>
> Mark the time KUnit test, time64_to_tm_test_date_range, as slow using test
> attributes.
>
> This test ran relatively much slower than most other KUnit tests.
>
> By marking this test as slow, the test can now be filtered using the KUnit
> test attribute filtering feature. Example: --filter "speed>slow". This will
> run only the tests that have speeds faster than slow. The slow attribute
> will also be outputted in KTAP.
>
> Signed-off-by: Rae Moar <rmoar@xxxxxxxxxx>
> ---

Thanks: this test is slow enough to really annoy me on some machines.
(It's possibly even on the edge of "very_slow" territory, though I
suspect "slow" is better.)

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

Cheers,
-- David


>
> Changes since v1:
> - No changes.
>
>  kernel/time/time_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/time/time_test.c b/kernel/time/time_test.c
> index 831e8e779ace..ca058c8af6ba 100644
> --- a/kernel/time/time_test.c
> +++ b/kernel/time/time_test.c
> @@ -86,7 +86,7 @@ static void time64_to_tm_test_date_range(struct kunit *test)
>  }
>
>  static struct kunit_case time_test_cases[] = {
> -       KUNIT_CASE(time64_to_tm_test_date_range),
> +       KUNIT_CASE_SLOW(time64_to_tm_test_date_range),
>         {}
>  };
>
> --
> 2.41.0.255.g8b1d071c50-goog
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature