Re: linux-next: Fixes tag needs some work in the v4l-dvb-fixes tree

From: Sakari Ailus
Date: Tue Jul 18 2023 - 02:09:22 EST


On Mon, Jul 17, 2023 at 06:58:28PM +0300, Kalle Valo wrote:
> Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> writes:
>
> > On Fri, Jul 14, 2023 at 08:38:25AM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> In commit
> >>
> >> b0b43354c345 ("media: tc358746: Address compiler warnings")
> >>
> >> Fixes tag
> >>
> >> Fixes: 80a21da3605 ("media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver")
> >>
> >> has these problem(s):
> >>
> >> - SHA1 should be at least 12 digits long
> >> This can be fixed for the future by setting core.abbrev to 12 (or
> >> more) or (for git v2.11 or later) just making sure it is not set
> >> (or set to "auto").
> >>
> >> Also, please keep all the commit message tags together at the end of
> >> the commit message.
> >
> > Apologies for this, I guess I've removed one character too many from the
> > hash.
> >
> > I'll switch to a script (or alias) to do this. It'd be, though, helpful if
> > git could do this on its own.
>
> Are you asking for git to create the Fixes tag? The documentation has
> has a tip using --pretty=fixes which is quite handy:
>
> https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

Thanks! This is much nicer than a bash alias I created.

--
Sakari Ailus