Re: [PATCH 2/5] mm: use vma_is_stack() and vma_is_heap()

[Kefeng Wang]

On 2023/7/17 18:25, David Hildenbrand wrote:
> On 12.07.23 16:38, Kefeng Wang wrote:
> > Use the helpers to simplify code.
> >
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
> > ---
> >   fs/proc/task_mmu.c   | 24 ++++--------------------
> >   fs/proc/task_nommu.c | 15 +--------------
> >   2 files changed, 5 insertions(+), 34 deletions(-)
>
> Please squash patch #1 and this patch and call it something like
>
> "mm: factor out VMA stack and heap checks"
>
> And then, maybe also keep the comments in these functions, they sound 
> reasonable to have.

Thanks, will re-post them.
>