RE: [PATCH] taging: fbtft: Add space around '='

From: Ping-Ke Shih
Date: Mon Jul 17 2023 - 20:30:50 EST




> -----Original Message-----
> From: hanyu001@xxxxxxxxxx <hanyu001@xxxxxxxxxx>
> Sent: Monday, July 17, 2023 4:16 PM
> To: toke@xxxxxxx; kvalo@xxxxxxxxxx
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] taging: fbtft: Add space around '='
>
> Fix checkpatch warnings:
>
> ./drivers/staging/media/av7110/dvb_filter.c:105: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:106: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:108: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:112: ERROR: spaces required
> around that '=' (ctx:VxV)
>
> Signed-off-by: maqimei <2433033762@xxxxxx>
> ---
> drivers/staging/media/av7110/dvb_filter.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/av7110/dvb_filter.c
> b/drivers/staging/media/av7110/dvb_filter.c
> index 8c2eca5..014fa1f 100644
> --- a/drivers/staging/media/av7110/dvb_filter.c
> +++ b/drivers/staging/media/av7110/dvb_filter.c
> @@ -102,14 +102,14 @@ int dvb_filter_pes2ts(struct dvb_filter_pes2ts
> *p2ts, unsigned char *pes,
> }
> if (!len)
> return 0;
> - buf[3]=0x30|((p2ts->cc++)&0x0f);
> - rest=183-len;
> + buf[3] = 0x30|((p2ts->cc++)&0x0f);
> + rest = 183-len;

Adding spaces around operators | and & would look better:
buf[3] = 0x30 | ((p2ts->cc++) & 0x0f);
rest = 183 - len;