[patch 55/58] x86/apic: Mark all hotpath APIC callback wrappers __always_inline

From: Thomas Gleixner
Date: Mon Jul 17 2023 - 19:37:03 EST


There is no value for instrumentation to look at those wrappers and with the
upcoming conversion to static calls even less so.

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
---
arch/x86/include/asm/apic.h | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)

--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -370,62 +370,62 @@ void __init apic_install_driver(struct a
pr_info("APIC::%s() replaced with %ps()\n", #_callback, _fn); \
}

-static inline u32 apic_read(u32 reg)
+static __always_inline u32 apic_read(u32 reg)
{
return apic->read(reg);
}

-static inline void apic_write(u32 reg, u32 val)
+static __always_inline void apic_write(u32 reg, u32 val)
{
apic->write(reg, val);
}

-static inline void apic_eoi(void)
+static __always_inline void apic_eoi(void)
{
apic->eoi();
}

-static inline void apic_native_eoi(void)
+static __always_inline void apic_native_eoi(void)
{
apic->native_eoi();
}

-static inline u64 apic_icr_read(void)
+static __always_inline u64 apic_icr_read(void)
{
return apic->icr_read();
}

-static inline void apic_icr_write(u32 low, u32 high)
+static __always_inline void apic_icr_write(u32 low, u32 high)
{
apic->icr_write(low, high);
}

-static inline void apic_wait_icr_idle(void)
+static __always_inline void apic_wait_icr_idle(void)
{
if (apic->wait_icr_idle)
apic->wait_icr_idle();
}

-static inline u32 safe_apic_wait_icr_idle(void)
+static __always_inline u32 safe_apic_wait_icr_idle(void)
{
return apic->safe_wait_icr_idle ? apic->safe_wait_icr_idle() : 0;
}

-static inline bool apic_id_valid(u32 apic_id)
+static __always_inline bool apic_id_valid(u32 apic_id)
{
return apic_id <= apic->max_apic_id;
}

#else /* CONFIG_X86_LOCAL_APIC */

-static inline u32 apic_read(u32 reg) { return 0; }
-static inline void apic_write(u32 reg, u32 val) { }
-static inline void apic_eoi(void) { }
-static inline u64 apic_icr_read(void) { return 0; }
-static inline void apic_icr_write(u32 low, u32 high) { }
-static inline void apic_wait_icr_idle(void) { }
-static inline u32 safe_apic_wait_icr_idle(void) { return 0; }
-static inline void apic_set_eoi(void (*eoi)(void)) {}
+static __always_inline u32 apic_read(u32 reg) { return 0; }
+static __always_inline void apic_write(u32 reg, u32 val) { }
+static __always_inline void apic_eoi(void) { }
+static __always_inline u64 apic_icr_read(void) { return 0; }
+static __always_inline void apic_icr_write(u32 low, u32 high) { }
+static __always_inline void apic_wait_icr_idle(void) { }
+static __always_inline u32 safe_apic_wait_icr_idle(void) { return 0; }
+static __always_inline void apic_set_eoi(void (*eoi)(void)) {}

#endif /* CONFIG_X86_LOCAL_APIC */